bug #86756: klistview::selectedItems() returns hidden items

[Aaron Seigo]

On September 13, 2004 8:05, Sebastian Sauer wrote:
> Around 5 weeks ago I found a very strange behaviour in KListView (see
> http://bugs.kde.org/show_bug.cgi?id=86756) that could result in lost of
> data. I attached a patch (simple oneliner) at the bugreport to fix it.
>
> I am not sure what it means if nobody replies there. I am allowed to commit
> the fix? Any kind of answer is welcome cause if the bug isn't
> relevant/reproducable I just would like to close and ignore it. Thanks in
> advance and keep up the great coding.

as a developer, i'd be surprised if it didn't return hidden items as well. i 
may very well WANT to have the hidden items returned, and with your patch 
that isn't possible. no, if the action should operate only on visible items 
the code should check for that. if anything, an overloaded method that allows 
one to define visible only or all selected items may be in order for 
convenience, but changing those semantics may not be the best thing?

as for why it's stayed for 5 weeks w/out comment: we recently had aKademy, and 
now Scott who does a lot of the maintenance on KListView these days AFAIK is 
in Chile on (semi-)vacation =)

-- 
Aaron J. Seigo
Society is Geometric