[patch] spellcheck KTextEditor

[Matt Rogers]

On Sunday 17 October 2004 09:07 am, Jaroslaw Staniek wrote:
> > On Saturday 16 October 2004 06:37 pm, Jarosław Staniek wrote:
> >>(I've commented out the code but wil finally remove it)
> >>
> >>1. checkSpellingEnabled() turns spell checking for this text edit on or
> >>off, so I've a fix that hides the item in KTextEdit::createPopupMenu()
> >> and also an item for "Auto Spell Check"
> >
> > I don't like the fact that you hide the item. You should disable it
> > instead. I hope aseigo would back me up on the fact that this is better
> > usability than hiding the item.
>
> Disabling an item indicates that the option can be enabled in certain
> cases. That's not true for _many_ cases (e.g. for me: in code editors).
>

yeah, but you have to think of the normal user when you say it's not true for 
many cases. How often does a normal user use a code editor? I think it's best 
this discussion get moved to kde-usability.

> >>2. Is toggleAutoSpellCheck() really work as expected? Hmm, what is
> >> expected here?
> >
> > why wouldn't it work as expected? If d->checkSpellingEnabled is false,
> > then calling setCheckSpellingEnabled( !d->checkSpellingEnabled ) enables
> > spell checking, and vice versa. Automatic spell checking is done
> > automatically when spell checking is on, AFAIK.
> >
> >>3. Proposal: Hide "Allow Tabulations" in popup menu by default to
> >> decrease cluttering? Could it be usable in just 1% of applications?
> >> Let's developers decide to enable it depending on contents (eg. I want
> >> it always on for source code editors).
> >
> > I don't even know what Tabulations are, so i don't see the problem in
> > hiding it by default, but perhaps somebody who knows what tabulations are
> > should comment.
>
> bool QTextEdit::tabChangesFocus () const
>
> Returns TRUE if TAB changes focus or is accepted as input; otherwise
> returns FALSE. See the "tabChangesFocus" property for details.
>
> --rarely used, that's why I see the gui is cluttered because of such
> options.

I would agree, but again, i think somebody from kde-usability should provide 
some input. (I've cc-ed that list to move the discussion there)

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20041017/0aa78e7c/attachment.sig>