[patch] spellcheck KTextEditor

[Jaroslaw Staniek]

> On Saturday 16 October 2004 06:37 pm, Jarosław Staniek wrote:
> 
>>(I've commented out the code but wil finally remove it)
>>
>>1. checkSpellingEnabled() turns spell checking for this text edit on or
>>off, so I've a fix that hides the item in KTextEdit::createPopupMenu() and
>>also an item for "Auto Spell Check"
>>
> 
> I don't like the fact that you hide the item. You should disable it instead. I 
> hope aseigo would back me up on the fact that this is better usability than 
> hiding the item.

Disabling an item indicates that the option can be enabled in certain cases. 
That's not true for _many_ cases (e.g. for me: in code editors).

>>2. Is toggleAutoSpellCheck() really work as expected? Hmm, what is expected
>>here?
>>
> why wouldn't it work as expected? If d->checkSpellingEnabled is false, then 
> calling setCheckSpellingEnabled( !d->checkSpellingEnabled ) enables spell 
> checking, and vice versa. Automatic spell checking is done automatically when 
> spell checking is on, AFAIK.
> 
> 
>>3. Proposal: Hide "Allow Tabulations" in popup menu by default to decrease
>>cluttering? Could it be usable in just 1% of applications? Let's developers
>>decide to enable it depending on contents (eg. I want it always on for
>>source code editors).
> 
> 
> I don't even know what Tabulations are, so i don't see the problem in hiding 
> it by default, but perhaps somebody who knows what tabulations are should 
> comment.

bool QTextEdit::tabChangesFocus () const

Returns TRUE if TAB changes focus or is accepted as input; otherwise returns 
FALSE. See the "tabChangesFocus" property for details.

--rarely used, that's why I see the gui is cluttered because of such options.

-- 
regards / pozdrawiam,
  Jaroslaw Staniek / OpenOffice Polska
  Kexi Project: http://www.kexi-project.org, http://koffice.kde.org/kexi
  KDElibs/Windows: http://wiki.kde.org/tiki-index.php?page=KDElibs+for+win32