[patch] enhanced file properties dialog

[David Faure]

On Monday 11 October 2004 23:16, Martin Koller wrote:
> On Monday 11 October 2004 21:16, Martin Koller wrote:
> > >
> > > ? Do we? Oh indeed. Never realized that.
> > > I would accept a patch that changes it to only do it for directories.
> >
> > Good. Will change that.
> 
> What do you think about the attached patch ?

Looks great to me. It's pretty cool that the info in the Devices tab update when
playing around with the combobox :)
Please commit.

> > > If you mean for directories: if all the info provided by the metainfo is
> > > already there (or can easily be made to be), then we could hide the
> > > metainfo tab indeed.
> >
> > Yes.
> 
> The current meta info only shows size and files (in the first level of the 
> directory).
> The Size/Files on the first property tab shows always the complete (recursive) 
> size/files of the folder.
> If this is not important, we could simply scratch
> kdeaddons/kfile-plugins/folder

I'm not sure this is a good idea. Meta-info is used in other places than the
properties dialog. For instance in tooltips. Or in other applications, possibly. 

I would rather go the other way around and avoid loading the metainfo for dirs,
in the properties dialog.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).