[patch] minicli sizing
adawit at kde.org
Sun Nov 7 15:37:03 GMT 2004
On Tuesday 02 November 2004 01:18, Martin Koller wrote:
> On Tuesday 02 November 2004 01:46, Dawit A. wrote:
> > > > With your change, the size of the
> > > > combobox will grow infinitely with the size of the URL which is
> > > > worse.
> > >
> > > Can you tell me details, please? When will it grow (by doing what) ?
> > > I can't see why it should.
> > Simple. If you type or paste a very long URL then the next time you
> > restart KDE, kdesktop actually, the minimum size of the minicli would be
> > the size of the longest URL in the combobox.
> Did you actually try my patch ?
Not yet. I simply read the patch, but I remembered a similar implementation
that did not work before...
> I can not reproduce this behaviour.
I will have to test it and see...
> OK. But is it so bad that I can actually resize the dialog, when the
> mentioned problem is solved ?
Not so long as it does not result in the growing box problem. Will have to
> > > I was trying to solve this in a clean way (probably I failed, but then
> > > please give me a test case where it does not work and I'll try to
> > > improve it).
> > You can try, but it will not work. Like I said many have attempted before
> > (see the commit logs) and it has always failed!
> To be honest - that's no reason for me to not try it again.
I was not trying to discourage you, but we have been down this road so many
times it gets old after a while :) If your patch indeed works, then I will
remove my objection about it...
"Preach what you practice, practice what you preach"
More information about the kde-core-devel