KProcess: writeStdin API braindamage

Waldo Bastian bastian at kde.org
Tue Mar 23 15:48:27 GMT 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Now that KProcess creates non-blocking pipes to its child processes it becomes 
clear that the semantics of the writeStdin function are brain dead: hardly 
any caller makes sure that the data that was passed stays alive long enough 
(t.i. till a wroteStdin signal arrives)

This patches corrects that, by making a local copy of the data if the data 
could not be directly written into the pipe. This fixes pasting large amounts 
of data into konsole.

Please review.

Cheers,
Waldo
- -- 
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
^ bastian at kde.org | Is your software SUSE LINUX READY? | bastian at suse.com
^<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAYFxMN4pvrENfboIRAghzAJ9vQj9E81W9owLxoOsDAhfQoS9pHgCfTjuh
H+CzG7ESOgTYjePPimdTUco=
=z+Ss
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kprocess.patch
Type: text/x-diff
Size: 3072 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040323/fabe54e2/attachment.patch>


More information about the kde-core-devel mailing list