Extending KCModuleProxy

Matthias Kretz kretz at kde.org
Tue Mar 16 13:27:01 GMT 2004

Hash: SHA1

Hi Frans,

first of all thank you for documenting the KCModuleProxy class.

A few remarks on what I've seen (I've only looked through the diff - no 
testing done):
- - Reading the diff was really hard because you reordered the code and changed 
the indenting. So I had to manually diff the old and new code :-(
- - Please don't remove the vim modeline. People using vim automatically will 
use the right indentation style if it's present.
- - The changed signal is not identical to the one of the embedded KCM. The 
changed signal of the proxy is only emitted if the KCM really changed. If 
changed() == true and the KCM emits changed(true) the proxy won't emit the 
changed signal.
- - there's an i18n call missing when creating the KCMError object
- - The proxy was supposed to be really light weight. Just think of the Kontact 
config dlg which has sth. like 30 KCMs or so. The proxy makes lazy loading 
easy and without a lot of overhead. The new implementation doesn't look very 
optimised on that regard (If I read correctly it even doesn't do lazy loading 
anymore). I'd like to see some numbers like how long it takes to create the 
Kontact config dlg.

before I can continue to make usefull comments I'd need to know if you really 
did throw out lazy loading...

JFYI: KCModuleProxy was supposed to do two things:
1. sane changed handling
2. easy lazy loading
This is very different from what the ProxyWidget in KControl does so the idea 
never occured to me to merge the two.

On Monday 15 March 2004 02:09, Frans Englich wrote:
> I've done some KCM work lately, namely trying to disentangle all the
> various helper classes, wrapper classes etc. related to using KCMs.

- -- 
Matthias Kretz (Germany)                          <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
Version: GnuPG v1.2.4 (GNU/Linux)


More information about the kde-core-devel mailing list