PATCH: Bug 73440: Konq deletes files when dragging

[Dawit A.]

On Sunday 07 March 2004 16:52, David Faure wrote:

> I think there is some confusion here.
> Overwriting a file by dropping another file on top of it in Konqueror,
> and writing to a file from within an application, are two very different
> things.

And that is exactly the problem. Specially for remote protocols. For example, 
in kio_sftp where I have applied the same fix as kio_file if you edit a 
symlink to a text file in kate and save it, the symlink gets converted into 
an actual file which is not the intended behavior. So this cannot be 
implemented in remote protocols and as such we cannot protect against 73440 
like bugs with remote protocols.

> While I believe the first one should not follow symlinks (see the initial
> part of the thread), the second one should obviously follow symlinks!!
> If it doesn't do that anymore, then it's a regression introduced by the fix
> for the first case. This means Dawit's fix needs work....

Well I cannot duplicate the problem with Kate. I do not know what Kompare is 
doing for Andras to see the problem though. Perhaps they unnecessarily set 
the overwrite flag in which case the problem definitely will show up...

> > I have posted the patch to fix the problem another way
> > if necessary. See here: http://lists.kde.org/?t=107679141300008&r=1&w=2
>
> The check on linkDest pointing to the file itself looks good to me.
> This should be committed IMHO, and although it fixes 73440, it doesn't
> change the fact that IMHO dropping a file onto a symlink shouldn't
> update the symlink's target. But if fixing this in KIO is too low-level 
> (and breaks saving to a symlink from other apps) then I guess the fix
> should be done in libkonq (KonqOperations?).

That is just it though. My only intention was to fix 73440 :) I will commit 
the linkDest check stuff. 
-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"