Possible bug crash in KStringHandler (kdelibs/kdecore/kstringhandler.cpp).

Oswald Buddenhagen ossi at kde.org
Tue Jun 29 13:41:06 BST 2004


On Tue, Jun 29, 2004 at 07:36:53AM -0500, Matt Rogers wrote:
> On Monday 28 June 2004 08:47 am, Oswald Buddenhagen wrote:
> > On Sun, Jun 27, 2004 at 10:26:20PM +0200, Michel Hermier wrote:
> > > I found a possible crash bug in KStringHandler::isUtf8( const char *).
> > > This method is not protected against null char *.
> >
> > imo this is a feature, not a bug ... :)
> >
> I'm a bit confused. Is this a bad patch, or are you just being funny?
> 
i think it is stupid to make functions silently swallow invalid input;
an assertion failure is the proper reaction if no explicit status code
is returned. whether a null string is invalid input is another
question, but imo it is.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.




More information about the kde-core-devel mailing list