Olivier Goffart ogoffart at
Tue Jun 8 18:40:38 BST 2004

Le Mardi 8 Juin 2004 14:26, Benjamin Meyer a écrit :
> On Tuesday 08 June 2004 8:03 am, David Faure wrote:
> > On Tuesday 08 June 2004 02:07, Benjamin Meyer wrote:
> > > Also Added All to the enum.
> >
> > Is that a good idea, in terms of extensibility? If you add another
> > feature to the method later, you will be faced with two bad
> > possibilities: * adding the new feature to All, which would change
> > existing behavior, * or having a "All" that doesn't really mean "All",
> > since one feature will be missing...
> >
> > Apart from that, the patch looks ok to me now.
> Remove the All and comited.

The "All" was great. :-(

I guess you removed it only for the extensibility reason.
But you let a default value in the fonction which has exactly the same 

I would put back the All.

We could also do  All = 65535  which means "All" has automaticaly all flags. 
But i don't know if it's a good idea for backward compatibility

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list