createStandardKWindow()
Benjamin Meyer
ben at meyerhome.net
Tue Jun 8 15:26:00 BST 2004
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tuesday 08 June 2004 8:03 am, David Faure wrote:
> On Tuesday 08 June 2004 02:07, Benjamin Meyer wrote:
> > Also Added All to the enum.
>
> Is that a good idea, in terms of extensibility? If you add another feature
> to the method later, you will be faced with two bad possibilities:
> * adding the new feature to All, which would change existing behavior,
> * or having a "All" that doesn't really mean "All", since one feature will
> be missing...
>
> Apart from that, the patch looks ok to me now.
Remove the All and comited.
- -Benjamin Meyer
- --
Public Key: http://www.csh.rit.edu/~benjamin/public_key.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQFAxczI1rZ3LTw38vIRAu6hAJ4vIuKLu0JNhfj36UGt360dTZhW2QCfQu4L
DhVtr8p0wATxpT6r+rr/rfw=
=YLi1
-----END PGP SIGNATURE-----
More information about the kde-core-devel
mailing list