[PATCH] Revised patch for KUser

[André Wöbbeking]

On Monday 07 June 2004 23:04, Harri Porten wrote:
> On Mon, 7 Jun 2004, Jan [iso-8859-15] Schäfer wrote:
> > I have revised my changes according to your comments.
> > The new patch is attached.
>
> I see no reference counting and delete statement. At first sight it
> looks like 'd' will be leaking.

you oversaw the KSharedPtr :-) (me too at the first look)

> A optimization suggestion: the temporary allGroups and users
> variables
>
>   QValueList<KUserGroup> allGroups = KUserGroup::allGroups();
>   QValueList<KUser> users = group.users();
>
> can probably be declared const to avoid detaching.

I think you mean const&.


André