[PATCH] Revised patch for KUser
porten at froglogic.com
Mon Jun 7 22:04:20 BST 2004
On Mon, 7 Jun 2004, Jan [iso-8859-15] Schäfer wrote:
> I have revised my changes according to your comments.
> The new patch is attached.
I see no reference counting and delete statement. At first sight it looks
like 'd' will be leaking.
A optimization suggestion: the temporary allGroups and users variables
QValueList<KUserGroup> allGroups = KUserGroup::allGroups();
QValueList<KUser> users = group.users();
can probably be declared const to avoid detaching.
More information about the kde-core-devel