PATCH: kwallet lockup (#65978/#71048)

Lubos Lunak l.lunak at suse.cz
Wed Jan 14 12:12:48 GMT 2004


On Tuesday 13 of January 2004 10:55, Lubos Lunak wrote:
> On Monday 12 of January 2004 18:17, Dirk Mueller wrote:
> > On Monday 12 January 2004 18:08, Lubos Lunak wrote:
[snip]
> > seems like khtml has to be converted to use the asynchronous api,
> > something
>
>  Not only khtml, but everything that can create a popup, otherwise the
> kwallet<->popup deadlock can occur.
>
> > which I wanted to avoid since  while it might close this problem, it will
> > open an extremely huge can of worms inside khtml. I'm really not very
> > confident in changing something like this in this phase of the release
> > cycle.
>
>  I think making the kwallet call blocking and closing all popups before it
> is a sufficient solution for 3.2. Ok, not updating the GUI may be
> significant, but the world will not tumble down. All other solutions I see
> are either worse, or need to be post-3.2 (be it making TT create some
> proper
> qApp->eventLoop()->processEvent( OnlyUpdateGUI ) or whatever).

 Please review the attached patch. It reverts back to r1.42 (blocking DCOP 
call), and closes all open popups in the application before the call.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwallet.cc.patch
Type: text/x-diff
Size: 1056 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040114/05212652/attachment.patch>


More information about the kde-core-devel mailing list