PATCH: kwallet lockup (#65978/#71048)

[Lubos Lunak]

On Monday 12 of January 2004 17:33, George Staikos wrote:
> On Monday 12 January 2004 11:24, Lubos Lunak wrote:
> > > >  That's not going to be only khtml, that's going to be everything
> > > > using kwallet. I'm not sure if people would like to always have to
> > > > open wallets asynchronously.
> > >
> > >   Exactly, reverting callExt for all applications will probably break
> > > many of them.
> >
> >  What do you expect to break, besides the popup lockup? I was only
> > suggesting that people might not like API-wise being forced to open the
> > wallet asynchronously, I don't see any potential problem with making the
> > call not to use event loop and only somehow handle the popup problem.
>
>    The GUI stops updating while it blocks in the DCOP call in synchronous
> mode without using callExt.

 I'm afraid GUI not updating is insignificant when compared to crashes or 
lockups. Code in libraries should IMHO never re-enter the event loop, because 
you never know what the event loop might do in the middle of something that's 
considered to be "atomic" by the developer calling it.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/