PATCH: Bug 72230: RMB "Open in new window" on a HTML link to an image makes...
bastian at kde.org
Sat Jan 10 23:49:39 GMT 2004
-----BEGIN PGP SIGNED MESSAGE-----
On Sat January 10 2004 20:53, Dawit A. wrote:
> On Saturday 10 January 2004 11:01, Waldo Bastian wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > On Sat January 10 2004 07:38, Dawit A. wrote:
> > > Hello,
> > >
> > > The attached patch fixes BR# 72230. Waldo you commited this as part of
> > > the Referrer fixes in rev 1.872. Is there a reason why the service type
> > > needs to be set ?
> > To get servicemenus that relate to text/html instead of
> > application/octet-stream.
> Wouldn't that still be wrong since the link in this case is an image ?
Yes, in some cases yes. The problem is that mimetype detection based on
filenames is rather unreliable too for http URLs and doing real mimetype
detection would mean a server round-trip which takes too long.
> > Maybe we should just reset it in popupUrlArgs in
> > KonqMainWindow::slotPopupMenu, see patch (seems to fix it just fine).
> Dunno about its correctness, but it does fix the bug...
bastian at kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
-----END PGP SIGNATURE-----
More information about the kde-core-devel