PATCH: Bug 72230: RMB "Open in new window" on a HTML link to an image makes...

Dawit A. adawit at kde.org
Sat Jan 10 19:53:49 GMT 2004


On Saturday 10 January 2004 11:01, Waldo Bastian wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sat January 10 2004 07:38, Dawit A. wrote:
> > Hello,
> >
> > The attached patch fixes BR# 72230. Waldo you commited this as part of
> > the Referrer fixes in rev 1.872. Is there a reason why the service type
> > needs to be set ?
>
> To get servicemenus that relate to text/html instead of
> application/octet-stream.

Wouldn't that still be wrong since the link in this case is an image ?

> Maybe we should just reset it in popupUrlArgs in
> KonqMainWindow::slotPopupMenu, see patch (seems to fix it just fine).

Dunno about its correctness, but it does fix the bug...

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"




More information about the kde-core-devel mailing list