[PATCH] DrKonqi detection of invalid backtraces

Lubos Lunak l.lunak at suse.cz
Thu Feb 5 14:57:09 GMT 2004


 Hello,

 now that we're talking about the number of bugreports and so on: I've noticed 
DrKonqi has had code for detection of useless backtraces since a long time 
ago. The slight problem is only that it usually doesn't work, as 
QString::find() rarely returns 0, especially in cases when there's no match. 
The attached patch fixes that, adds a short explanation to the backtrace tab 
in DrKonqi, and while I was at that, I changed DrKonqi not to have the 
regexps for detection hardcoded. Just try the attached testapp to see how it 
works.

 Ok to commit, and possibly backport (that would mean i18n changes, but IMHO 
it'd be worth it)? Should it show useless (well, recognized as useless) 
backtraces at all (human stupidity should not be underestimated, I wouldn't 
be that surprised to see one such backtrace pasted at bugs.kde.org together 
with the explanation saying it's useless)?

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drkonqi.patch
Type: text/x-diff
Size: 5380 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040205/58534bf3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a.cpp
Type: text/x-c++src
Size: 1475 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040205/58534bf3/attachment.cpp>


More information about the kde-core-devel mailing list