[patch] konqi multi column view #42587

[Martin Koller]

On Friday 03 December 2004 22:01, David Faure wrote:
> On Friday 03 December 2004 21:52, Martin Koller wrote:
> > Hi all,
> >
> > I've another patch for konqi addressing
> > http://bugs.kde.org/show_bug.cgi?id=42587
> >
> > I solve this by not setting a fixed grid when the text is to the right of
> > the icon. Then the widget already does a good job in calculating the
> > variable(!) column width.
> >
> > In addition, the user can set the maximum width (by using the TextWidth I
> > added recently to konq_settings, but now using it not for the desktop).
> >
> > I also included this to the File Manager/Appearance kcontrol Module.
> >
> > Can I commit ?
>
> I'm not sure which approach is best, but did you see the patch from
> Michael Mellor on kde-devel? It also addresses #42587 but with a different
> solution. From a quick reading it doesn't set a max width, so I guess it
> probably disables wordwrap altogether?

In principle, the patches have the same idea.
Michael also sets a maximum width, but it's hardcoded to 1000, and the patch 
only works for textlines == 1, which is a problem if a user switches from 
IconView mode to multicolumn mode, as this setting is not per view mode
(and the default is 2 textlines).

Due to these limitations, I think my approach is the better one, also as the 
user can decide the max width he wants.

> > P.S.: And I also set the icons to non moveable in file manager mode as
> > this does not make any sense, I think.
>
> Hmm, this is arguable. All file managers allow moving them, don't they?

Which file managers do you mean ?
Konqi did this, but it gives the user the impression he can decide where to 
put the icons, to finally find that after a reload/change dir the icons are 
again on the original positions.
As long as we do not store the positions per folder (which I would not do), 
it's clearer to have them non moveable.

> PS: missing each other's patches wouldn't happen if this was discussed
> on kfm-devel, which is the right list for this :)

Ah, ok. But can you give me a hint where is the borderline between things for 
core-devel and kfm-devel ? Is it only libkonq ?

Thanks.

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

       Some operating systems are called 'user friendly',
             Linux however is 'expert friendly'.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20041203/ef0fbed3/attachment.sig>