PATCH: [Bug 83064] SMB URI syntax error

[Dawit A.]

On Monday 09 August 2004 09:51, David Faure wrote:
> On Friday 30 July 2004 14:32, Dawit A. wrote:
> I disagree with that change. ftp.foo.bar is an FTP site, as the "ftp."
> denotes. Yes, some ftp sites can also be http sites, but it's easy to type
> http://ftp.kde.org in such a (more seldom) case.
>
> ftp.kde.org supports both, but not all ftp sites do. Did any user complain
> that ftp.foo.bar turns into ftp://ftp.foo.bar? I don't see any reason for
> this change.
>
> The fact that it's configurable doesn't change anything - this could also
> be an argument for not changing it, me telling you "you can always
> configure it locally"... :)

Do not worry. I did not change that at all because coolo provided a convincing 
argument why it should not change when I posted the original patch so it  
still works just like it did before.

> > That means now entering things of the form "blah:" will result in a
> > search using the default search engine.
>
> Hmm, is this related to http://bugs.kde.org/show_bug.cgi?id=76372 ?

Not directly. It was related to the issue of typing "smb:" producing some 
error message that coolo mentioned to me. Regarding BR#76372, we did not at 
anytime offer to replace a "keyword:" with a whole URL. At least not 
intentionally. This was never supported and if for some reason it worked that 
way during a prior release, then that was the bug. But I do not remember that 
ever being the case. In fact, I remember a wishlist item or two requesting 
support for such behavior. Whatever documentation states otherwise is IMHO 
wrong and needs to be fixed. Was this the quick help ? 

> > All these changes pass the regression test in kio/tests/kurifiltertest.
>
> Well you changed it accordingly :)

What fun would it be otherwise ? ;)

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"