[PATCH] ksplash progressbar (#86441)

Lubos Lunak l.lunak at suse.cz
Fri Aug 6 16:52:59 BST 2004


 (what'd expect fixing something as seemingly simple would take more than 5 

 In case you don't know, the progressbar in the 3.1 splashscreen served the 
following purpose: It was hidden until ksmserver started launching 
session-saved apps, and then it showed the progress of this. Since 3.2, the 
progressbar does two things:
- cuts of the first text about launching dcopserver (#86441 and its dupes), 
thus making the nice first impression we're lame
- shows exactly the same progress like the icons, thus making us look even 
more lame
 From the technical point of view, I've additionally found out KSplashML is 
not a fully KSplash replacement, as it handles the DCOP signals from 
ksmserver incorrectly and moreover it completely lacks the two DCOP signals 
ksmserver uses to announce the session restoration progress.

 Attached are two attempts at fixing this. First one implements the missing 
functionality and should match KSplash's behaviour. Since it seems the 
interface for KSplashML themes should stay BC, I had to use the two calls 
up-to-now used for the whole progress. Since I couldn't find any KSplashML 
themes HOWTO, I guess that can be considered part of fixing the problem, I 
checked all themes in CVS and they still work.

 Plan B patch is just a subset of the large one, only hidding the progressbar 
completely (and fixing blinking of the first icon, no idea why it was 
explicitly disabled).

 If this makes it in in time for RC1, and somebody has an idea for fixing 
#68643 (wrong colors in the progressbar), I'd suggest using the large patch. 
Since I won't have net access tommorrow, somebody please do the commit.

Lubos Lunak
KDE developer
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksplashml.patch
Type: text/x-diff
Size: 7723 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040806/b56226dc/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksplashml_plan_b.patch
Type: text/x-diff
Size: 1278 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040806/b56226dc/attachment-0001.patch>

More information about the kde-core-devel mailing list