[Patch] fix for kcm usbview update bug

Helge Deller deller at gmx.de
Sun Apr 18 21:59:29 BST 2004


On Sunday 18 April 2004 19:46, Leo Savernik wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello,
> 
> This patch fixes a bug where kcmusb is unable to detect when a new usb device 
> is plugged in or an existing one is removed.
> 
> I contacted Matthias Hölzer-Klüpfel about this ten days ago, but I haven't 
> received any reaction so far. Therefore, I'm asking for review here.
> 
> I think this patch is safe for backporting, too.

I think you should 
a) add the refreshTimer as member of the class,
b) stop the timer in USBViewer::~USBViewer() and
c) use I18N_NOOP("Live Monitoring of USB Bus") in your addCredit() call and not submit this line to the 3_2_BRANCH to avoid string changes/additions.

Helge




More information about the kde-core-devel mailing list