KMimeTypeChooser

Ravi ravi at kde.org
Mon Apr 12 19:45:16 BST 2004


> > > I kept the parent as the first argument, because there is a bunch of
> > > parameters with default values following.
> >
> > This could be solved using overloaded constructors. IMHO consistency is
> > king here, but that might be just me :}

[snip]

> Are the attached versions acceptable?

I second Simon's call for consistency. Please make the parent and name the 
last arguments. As a Qt/KDE programmer, I find that one of its greatest 
strengths is adherence to the principle* of least astonishment.

Regards,
Ravi

*Hoping Aaron would let me say this in a non-UI context :-)





More information about the kde-core-devel mailing list