[PATCH] Encoding box in the file dialog

[Ingo Klöcker]

On Thursday 25 September 2003 02:27, Carsten Pfeiffer wrote:
> On Wednesday 24 September 2003 10:46, Ingo Klöcker wrote:
> > KTextFileDialog is a bad name for this class. If the user wants to
> > attach a file in KMail, then KMail can't forsee whether this will
> > be a text file or a binary file. For text files we need the
> > encoding (cf. http://bugs.kde.org/show_bug.cgi?id=64815). So we
> > would always have to
>
> But this is confusing for all other types of files, then. The
> encoding selection box should be disabled when a non text/* file is
> selected. Also you can select multiple files in the attachments
> filedialog...

True. I didn't think about that.

> I think it's better to let the user choose the attachments freely and
> show a messagebox if he selected textfiles to make him consider
> changing their encoding. The encoding-entry in the
> attachments-listview could have an exclamation mark when an encoding
> was automatically chosen for a text-file.

This requires two actions with two dialogs for each text attachment. 
First selection of the file and then changing the encoding (if 
necessary). I still think that being able to select the encoding in the 
file dialog is nicer (even if the encoding is completely irrelevant for 
non-text attachments). If the user wants to attach multiple text files 
with different encoding then he'll either have to attach them one after 
the other or he'll have to change the encoding of some files after 
attaching them. It's no problem to add the encoding to the attachment 
properties dialog.

Regards,
Ingo