kdelibs/kdecore

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 23 September 2003 17:50, Zack Rusin wrote:
> On Tuesday 23 September 2003 05:19, Waldo Bastian wrote:
> > Indeed, thanks for the detailed report. It should be fixed now.
> >
> > When debugging I discovered that KMail uses two KConfig objects that
> > both operate on kmailrc. It would be more efficient if you could
> > manage to share a single configuration object. I assume that Kmail
> > uses two because one is used for the part and one is used for the
> > shell?
>
> If it has two then that's a bug. The only KConfig object that should
> operate on kmailrc is KMKernel::config() and that's the one it should
> always be used.

It uses two because KApplication creates one too.

The attached patch fixes KMail using the new KSharedConfig class. I had to do 
a little reworking: I store the config object with a refcounted 
KSharedConfig::Ptr in KMKernel, when KMKernel gets destructed the ptr gets 
derefed. In KMail the KApplication object (KInstance) will hold another 
reference. When KMKernel and KApplication have been destructed both the 
KConfig object will be deleted.

PS: In the "You forgot the attachment"-dialog the cursor remains a busy 
cursor.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/cZjYN4pvrENfboIRAtoLAKCND6KgLdw1L6kFzqwaIIBK+RWCEwCfSxWE
uYewUub/tP4jBPsBDWGEwig=
=wOSC
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail_config.patch
Type: text/x-diff
Size: 2417 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030924/75eb61b6/attachment.patch>