[PATCH] Show the clipboard history when pressing the Paste button

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 23 September 2003 10:36, Simon Hausmann wrote:
 
> I have to admit that I for one don't really like the idea of such a
> dependency. (What if klipper gets removed one day?) .
The menu can be removed? 

> Plus the menu 
> will always be visible, even if klipper is not running. It will
> appear as empty menu, which looks really ugly.
It's always visible, but it's not empty. It will show the current clipboard 
content.

> 
> Technically on the patch:
> 
> 1) The popupmenu appears to be leaked.
Oops, you're right.

> 2) It's _much_ easier to perform dcop calls with DCOPRef than to do
>    the (de)marshalling of the data manually
> 3) The if ( !client->isAttached() ) client->attach() is superfluous
>    IMHO

Well, this was mine first code dealing with DCOP calls from C++. I don't know 
how to change #2  yet, #3 is just to be safe, and if it's considered that 
it's not needed, I can remove.

Andras

> 
> Anyway, just my 2 cents.
> 
> Simon
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/cLKcTQdfac6L/08RAmUNAKDobuQD1+BSyGzM4rGvkC7RXGjuYgCgxssH
3QD2phlYKooRJbGYiJjxbV8=
=JOkW
-----END PGP SIGNATURE-----