[PATCH] Recent file action on toolbars

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 21 September 2003 17:54, Olivier Goffart wrote:
[...]
> I think KRecentFileAction is not the only KSelectAction which has this
> problem.
> I think, for KDE 3.3 that another class is needed.
> KSelectAction is designed to select one state, not realy to fire a selected
> action. For this usage, the ComboBox and the checkMark in the menu are 
great.
> 
> But when it is for executing a selected action (like for recent files, or 
even
> the move/copy to group in Kopete)  this is inapropriate
> 
> My point is that a new KAction type for this usage ( "executing" a selected
> action ) should be usefull...  (KListAction??)
But in this case KRecentFilesAction should inherit from that one and I don't 
think it can be done in a BC way. I believe my solution is a good compromise 
until KDE 4.0.

> 
> > if you use KStdAction::openRecent to get a pointer to a
> > KRecentFilesAction action, you have to manually call setIcon(), otherwise
> > the button will not have an icon.
> [...]
> > can't be solved in a clean way, only by
> > providing a new openRecent method which has an extra "icon" parameter.
> 
> This could be solved easily. We just need to create a default icon for
> openRecent and put it automaticaly.
Oh, you're right, but which icon should you select for default ? My suggestion 
is "fileopen" and I can patch the KStdAction::openRecent if there are no 
complains about the patch in general and this issue in particular.

Andras

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/be+ATQdfac6L/08RAj9DAJ4nQpThBkf1DcLCK5KZSBS/MSX5KwCcDS6b
B3nrUuETe1uJqGsR/DflJ7I=
=+pa3
-----END PGP SIGNATURE-----