[PATCH] Recent file action on toolbars

[Olivier Goffart]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Dimanche 21 Septembre 2003 14:19, Andras Mantia a écrit :
> Hi,
>
>  Datschge had an idea about improving the usability of the KDE applications
> by providing a list of the recently opened files on the toolbar in a
> similar way of how the history is presented in Konqueror: click on the icon
> brings up the open dialog and if you keep the mouse button pressed on the
> icon it shows you the recently opened files. I've implemented this in
> Quanta using the current kdelibs, but the goal would be to have it in every
> KDE application without much trouble.
>  Unfortunately the KRecentFilesAction plugged into the toolbar looks very
> ugly as it appears as (a large) combobox. My patch makes the
> KRecentFilesAction to show as the KToggleToolBarAction when it's plugged
> into a toolbar. The code itself is a simplified version of the
> KToggleToolBarAction code (eg. the popupmenu always appeares delayed). 

I think KRecentFileAction is not the only KSelectAction which has this 
problem.
I think, for KDE 3.3 that another class is needed.
KSelectAction is designed to select one state, not realy to fire a selected 
action. For this usage, the ComboBox and the checkMark in the menu are great.

But when it is for executing a selected action (like for recent files, or even 
the move/copy to group in Kopete)  this is inapropriate

My point is that a new KAction type for this usage ( "executing" a selected 
action ) should be usefull...  (KListAction??)

> if you use KStdAction::openRecent to get a pointer to a
> KRecentFilesAction action, you have to manually call setIcon(), otherwise
> the button will not have an icon.
[...]
> can't be solved in a clean way, only by
> providing a new openRecent method which has an extra "icon" parameter.

This could be solved easily. We just need to create a default icon for 
openRecent and put it automaticaly.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/bbufz58lY8jWrL0RAmzBAJ9qxIMMt0eNZxbMR49KiMsavLI7hACggiL4
lungUh9hdAbXJxTqeqMjI7U=
=iRT+
-----END PGP SIGNATURE-----