#57795 -a better patch.

Luciano Montanaro mikelima at virgilio.it
Sun Oct 26 14:48:58 GMT 2003


As suggested on the list, the size of the border of the icon should be 
calculated from the used style. This patch does it. I think I used the 
correct metrics - PM_ButtonMargin, but the documentation could be clearer.

I'd like to apply the patch and close my bug report if it is correct.

While testing out the patch, I discovered a minor problem with the properties 
dialog: the layout is slightly changed when the style is changed and the 
panel is open. Here is how to see the effect:

Open the properties dialog for the home directory^Wfolder,
launch the style module of the control center,
change style.

The icon box position changes, it looks like some margin settings are 
discarded.

Should I file a bug report about this? It is quite a minor problem.

Luciano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kpropertiesdialog.patch
Type: text/x-diff
Size: 1781 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031026/625fc7f7/attachment.patch>


More information about the kde-core-devel mailing list