[PATCH] KWinModule being over-enthousiastic

Richard Moore rich at xmelegance.org
Thu Oct 23 22:38:22 BST 2003


On Thursday 23 October 2003 14:54, Waldo Bastian wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Intro:
> KWinModule is a bit enthousiastic when it comes to monitoring stuff. It
> puts XSelectInputs on all windows that it can find while the caller might
> only be interested in desktop changes. That's bad for performance because
> it means that a lot of processes are being activated on every key or mouse
> click.

The patch looks good, but one potential issue is if someone tries to share the 
KWinModule between a few different (related) classes - I've done this before 
to minimise the overheads. How about adding another method that lets you say 
what things should be watched for after the construction has taken place (ie. 
one that ORs the flags together and updates the mask.

Cheers

Rich.





More information about the kde-core-devel mailing list