[PATCH] KWinModule being over-enthousiastic

[Lubos Lunak]

On Thursday 23 of October 2003 16:54, Waldo Bastian wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Intro:
> KWinModule is a bit enthousiastic when it comes to monitoring stuff. It
> puts XSelectInputs on all windows that it can find while the caller might
> only be interested in desktop changes. That's bad for performance because
> it means that a lot of processes are being activated on every key or mouse
> click.
>
> The following patch attempts to rectify this situation. It makes it
> possible for the caller to specify the information he/she is interested in.
>
> Please review.

 Looks fine in genral. But perhaps you could drop INFO_WORKAREA. Workareas are 
very specific thing and shouldn't be widely used anyway, and also the second 
workArea() function (with excludes) requires INFO_WINDOWS to work properly, 
which I think would be confusing.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/