patches for Sun Forte 7/8 compilers

David Faure faure at kde.org
Mon Nov 3 18:17:54 GMT 2003


On Monday 03 November 2003 17:44, Stefan Teleman wrote:
> Hi!
> 
> David Faure was kind enough to post the patches for SunOS/Sun Forte 
> 7/8 compilers at
> 
> http://www.blackie.dk/~dfaure/solaris/

And now kdebase and kdenetwork added.

What's with signal(), why was it replaced with KSignal everywhere?
Is there really no system header that defines FD_SETSIZE?
Why does it need the setrlimit? (what's the default amount of simultaneous files on Solaris?)
Are you sure that e.g. kfmclient needs this too? I doubt it, since kfmclient has a very
short lifetime. Same with ktelnetservice, etc. etc.
If all apps really need something to be done, the best place would be 
KApplication, not each and every main().

Warning: some of your patches actually revert some bugfixes that
were made in CVS. It looks like you did a diff against an updated tree....
For instance:
-      kapp->dcopClient()->call( "kded", "kcookiejar", "deleteCookiesFromDomain(QString)", params, replyType, replyData);
+      kapp->dcopClient()->call( "kded", "kcookiejar", "deleteCookiesFromDomain", params, replyType, replyData);
The first one was correct.
This is just a warning in case anyone starts to blindly apply those patches :)

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list