PATCH and a question, two bits

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

the window list (as seen in kdesktop or the taskbar windowlist button) shows 
all windows, even ones that have asked to be skipped by the taskbar. this 
results in odd behaviour like kicker panels showing up in the list. the 
following trivial patch fixes that, but led me to wondering: was this 
behaviour intentional? is there some reason for including windows that aren't 
to be shown in the taskbar in the window list menu?

Index: kwindowlistmenu.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kwindowlistmenu.cpp,v
retrieving revision 1.18
diff -u -3 -d -p -r1.18 kwindowlistmenu.cpp
- --- kwindowlistmenu.cpp 6 May 2003 09:44:55 -0000       1.18
+++ kwindowlistmenu.cpp 13 May 2003 23:47:37 -0000
@@ -188,7 +188,8 @@ void KWindowListMenu::init()
             NET::WindowType windowType = info->windowType( NET::NormalMask | 
NET::DesktopMask
                 | NET::DockMask | NET::ToolbarMask | NET::MenuMask | 
NET::DialogMask
                 | NET::OverrideMask | NET::TopMenuMask | NET::UtilityMask | 
NET::SplashMask );
- -            if ( windowType == NET::Normal || windowType == NET::Unknown ) {
+            if ( (windowType == NET::Normal || windowType == NET::Unknown) &&
+                 !(info->state() & NET::SkipTaskbar) ) {
                 QPixmap pm = KWin::icon(info->win(), 16, 16, true );
                 items++;
                 if (items == 1 && nd > 1)


- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE: The 'K' is for 'kick ass'
http://www.kde.org       http://promo.kde.org/3.1/feature_guide.php
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+wYSb1rcusafx20MRAnxfAJsGonSKOmyMaVhl1kq68+F+5pX9pQCfca96
pxaee86NbSjYOdFGDq2NC1Y=
=i1jx
-----END PGP SIGNATURE-----