[PATCHes] Retreival of meta data, and previews

Craig Drummond Craig.Drummond at gmx.net
Fri May 9 13:07:11 BST 2003


Hi,

I've noticed that the retreival of meta-data is not very consistent. For
example, it only works on the file:/ protocol for tooltips - but right-clicking
and selecting "properties" retreives the meta-data over other protocols. I've
attatched a few patches to try and resolve this.

previews.cpp.diff, browser.cpp.diff, filepreviews.desktop.diff all relate to
kdebase/kcontrol/konq. The main change is to make the "Previews" setting
also affect meta-data - this is onlly a comsetic string change.

kfileitem.cpp.diff is from kdelibs/kio/kio. Causes meta-data to be returned
only if enabled.

kmetaprops.cpp.diff relates to kdelibs/kio/kfile. This disables the
meta-data section of the properties dialog if it is not enable for the protocol.

konq_iconviewwidget.cc.diff is from kdebase/libkonq. This disables previews
in tooltips if not enabled for the protocol.


The only thing left is to disable the "info list view" of konqueror - not
sure how to do this yet.


Should I apply these patches? Or is there a better, lower-level way of doing
this? I thought of modifying MetaInfoJob, etc - so that this would only work
for specified protocols. However, most of the above cases do not use this -
plus it may also affect other apps who with to use MataInfoJob to get
meta-data over other protocols.


Craig.

-- 
+++ GMX - Mail, Messaging & more  http://www.gmx.net +++
Bitte l├Ącheln! Fotogalerie online mit GMX ohne eigene Homepage!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser.cpp.diff
Type: application/octet-stream
Size: 416 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: filepreviews.desktop.diff
Type: application/octet-stream
Size: 832 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfileitem.cpp.diff
Type: application/octet-stream
Size: 516 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmetaprops.cpp.diff
Type: application/octet-stream
Size: 496 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_iconviewwidget.cc.diff
Type: application/octet-stream
Size: 858 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: previews.cpp.diff
Type: application/octet-stream
Size: 1295 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030509/5ea34b1a/attachment-0005.obj>


More information about the kde-core-devel mailing list