[PATCH] Fix 49564 - please review

[Waldo Bastian]

On Wednesday 12 March 2003 18:53, Ravikiran Rajagopal wrote:
> > Other than that, when you do
> > 	if (config->readBoolEntry("CheckConfigFilesWritable",TRUE))
> > I don't think that any group is set. The command before does a
> > hasGroup(), not a setGroup().
>
> I thought about it. The trouble is this: which group does this need to go
> in? I could not think of a relevant group. Perhaps the action restrictions
> group is acceptable in order for the Kiosk framework to not show warnings?

yes, I would use a key like "warn_unwritable_config" and place it in that 
group. And document it in README.kiosk

> In that case, where does the user need to have it to disable this warning
> on a per app or per user basis? Or should we assume that the file being
> unwritable is always unintentional?

To disable it for this user only, in $KDEHOME/share/config/kdeglobals
To disable it for a single app only, in $KDEHOME/share/config/<app>rc
To disable it for all users, in $KDEDIR/share/config/kdeglobals

> > And why are parts between #ifdef Q_WS_X11 ? None of this is X specific.
>
> I don't know whether kdialog (the app) exists in the environment of
> embedded applications (I had Konq/E in mind). Is there a way of checking
> whether we are in a "normal" KDE environment? Or should I just rely on the
> findExe() call returning null.

I think relying on findExe() is good enough.

> I greatly appreciate your reviewing multiple versions of this patch. I am
> still learning my way around kdecore, and it has been great that people
> have been willing to correct me in a collegial manner.

You're welcome, it's nice to see new people that want to dig their way around 
in kdecore :)

Cheers,
Waldo
-- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com