[PATCH] Fix 49564 - please review

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Tue Mar 11 18:44:19 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 11 March 2003 07:23 am, Waldo Bastian wrote:
> I think it should mention the file that isn't writable. I would also like
> to see an explicit config key to disable the dialog instead of abusing the
> presence of the "[KDE Action Restrictions]" group for this.
>
> Other than that, I don't think it differentiates between the config file
> being unwritable because of file permissions and the config file being
> unwritable because the file starts with [$i] I think it's desirable not to
> give a warning in the latter case.

Objections noted, and hopefully fixed in the patch attached. Please review.

Regards,
Ravi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+bi6DbI8Y8y0oVXcRAo/DAJ42ig8nRUDMUD5qij68nbkHAwFcEwCfSzfg
CmV14GotPHNMB1E0bpp9eNg=
=MszI
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 49564.diff
Type: text/x-diff
Size: 4550 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030311/f769c4b8/attachment.diff>


More information about the kde-core-devel mailing list