[PATCH] Fix 49564 - please review

Waldo Bastian bastian at kde.org
Tue Mar 11 12:23:32 GMT 2003


On Monday 10 March 2003 20:00, Ravikiran Rajagopal wrote:
> Hello,
>   The following patch fixes bug 49564, which actually has been reported
> atleast 5 times to my knowledge (since KDE 2.0 days!). Thanks to David
> Faure for pointing out that KProcess is safe to use within the KApplication
> constructor. Is it ok to commit? To both branches?

I think it should mention the file that isn't writable. I would also like to 
see an explicit config key to disable the dialog instead of abusing the 
presence of the "[KDE Action Restrictions]" group for this.

Other than that, I don't think it differentiates between the config file being 
unwritable because of file permissions and the config file being unwritable 
because the file starts with [$i] I think it's desirable not to give a 
warning in the latter case.

Cheers,
Waldo
-- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com





More information about the kde-core-devel mailing list