[PATCH] Fix 53360 - String leak in DCOPClient

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Sun Mar 9 00:19:03 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Are you working with HEAD?
>
> The patch is against CVS HEAD, but it seems unnecessary given coolo's
> commit on 11 Feb which is almost the same as yours.

My mistake. I had fixed this a while ago, and when I updated CVS, I missed 
that this file was not updated. Sorry.

About the patch of Luis: I would still check that the local variables are not 
NULL before freeing them (paranoia, I presume :-) That said, I like your 
patch better. In case we stick with Coolo's patch, I would like to make sure 
that we initialize the variables to 0L in the constructor (paranoia again). 
Any thoughts?

Ravi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+aoh3bI8Y8y0oVXcRAte9AJwK3fvUfBfwSVbY5T8q8y5zeGGvGgCeMfXO
V1GvGCagFZgXi4OcS2HgOhs=
=qUcm
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list