[PATCH] dcopidl2cpp and templates

Tobias Koenig tokoe at kde.org
Mon Jul 14 22:10:51 BST 2003


Hi,

If you have an argument like QValueList< QPair<int,int> > in a dcop
method like in korganizer/kcalendariface, then dcopidl and dcopidl2cpp
transforms the '> >' to '>>'. With gcc3.3 this will lead to a warning
and a compilation stop.

The attached patch replaces all '>>' with '> >' in dcopidl2cpp again.
Is it ok for commit or do I miss a case, where '>>' can be a valid part of
a variable type?

Ciao,
Tobias
-- 
Can a government that shoots at reporters be democratic?
Seperate politics from religion and economy!
-------------- next part --------------
Index: skel.cpp
===================================================================
RCS file: /home/kde/kdelibs/dcop/dcopidl2cpp/skel.cpp,v
retrieving revision 1.26
diff -p -u -b -r1.26 skel.cpp
--- skel.cpp	19 Apr 2003 08:53:50 -0000	1.26
+++ skel.cpp	14 Jul 2003 21:02:55 -0000
@@ -263,7 +263,7 @@ void generateSkel( const QString& idl, c
 		QStringList::Iterator ittypes = argtypes.begin();
 		QStringList::Iterator args_count;
 		for( args_count = args.begin(); args_count != args.end(); ++args_count ){
-		    str << '\t'<< *ittypes << " " << *args_count << ";" <<  endl;
+		    str << '\t'<< (*ittypes).replace( ">>", "> >" ) << " " << *args_count << ";" <<  endl;
 		    ++ittypes;
 		}
 		str << "\tQDataStream arg( data, IO_ReadOnly );" << endl;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030714/dd51dc55/attachment.sig>


More information about the kde-core-devel mailing list