KIO::SlaveBase patch for yourconsideration

[Dawit A.]

X-BeenThere: kde-core-devel at mail.kde.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: kde-core-devel at kde.org
List-Id: KDE Core Development <kde-core-devel.mail.kde.org>
List-Unsubscribe: <http://mail.kde.org/mailman/listinfo/kde-core-devel>,
	<mailto:kde-core-devel-request at mail.kde.org?subject=unsubscribe>
List-Post: <mailto:kde-core-devel at mail.kde.org>
List-Help: <mailto:kde-core-devel-request at mail.kde.org?subject=help>
List-Subscribe: <http://mail.kde.org/mailman/listinfo/kde-core-devel>,
	<mailto:kde-core-devel-request at mail.kde.org?subject=subscribe>
Sender: kde-core-devel-bounces-+kde-kde-core-devel=m.gmane.org at mail.kde.org
Errors-To: kde-core-devel-bounces-+kde-kde-core-devel=m.gmane.org at mail.kde.org

On Sunday 13 July 2003 01:54, Alex Zepeda wrote:
> On Sun, Jul 13, 2003 at 01:06:24AM -0400, Dawit A. wrote:
> > storeAuthInfo is obsolete and should have been removed.  IIRC changing
> > the privilege level of member variables is NOT BC.
>
> It's not just storeAuthInfo, it's:
>
>     bool storeAuthInfo( const QCString&, const QCString&, const AuthInfo&
> ); UDSEntryList pendingListEntries;
>     uint listEntryCurrentSize;
>     long listEntry_sec, listEntry_usec;
>     Connection *appconn;
>     QString mPoolSocket;
>     QString mAppSocket;
>     bool mConnectedToApp;
>     static long s_seqNr;
>     virtual void virtual_hook( int id, void* data );
>
> that become protected instead of private.  FWIW I haven't run into any
> problems so far (and I haven't recompiled anything recently).

There is no need to repeat yourself.  I perfectly understood your original 
post.  I removed the storeAuthInfo stuff because I added it long ago and it 
is now an obsolete private function that can be safely removed.  Thanks for 
reminding me about it.

Having said that I neither see the need nor did you sufficiently clarify the 
reason you want to make the member variables protected so I did not to touch 
them.  Feel free to change that on your own if you want to take 
responsibility for it. :)

Regards,
Dawit A.