in-place-editing patch for konqueror bookmarks
oelewapperke at ulyssis.org
Sat Jan 18 02:11:47 GMT 2003
-----BEGIN PGP SIGNED MESSAGE-----
On Friday 17 January 2003 19:44, David Faure wrote:
> On Friday 17 January 2003 18:38, Oelewapperke wrote:
> > On Friday 17 January 2003 11:02, David Faure wrote:
> > > On Thursday 16 January 2003 23:02, Oelewapperke wrote:
> > > > On Thursday 16 January 2003 18:07, David Faure wrote:
> > > > > Please reconsider this. You rewrote a complete bookmarkbar
> > > > > implementation just to change the menus! There is much duplicated
> > > > > code in your patch, which I'm strongly against. This will become a
> > > > > maintainance hell.
> > > >
> > > > This is not true, check the code, I changed both the buttons and the
> > > > menus (and as far as I can see I need to do that)
> > >
> > > Ok, the KIPEToolBarButton indeed adds MMB/RMB to the buttons.
> > > But why a brand new KIPEBookmarkBar? Why not integrate this with
> > > the original bookmarkbar? We don't need to have two of them...
> > because the class delivers events, something which can not be done with
> > only a KBookmarkOwner, I need a KIPEBookmarkOwner for that.
> Implement it with signals, it'll be much simpler (since it will introduce
> no BIC problem, it can be done in the existing classes)
okay ... I have an exam on monday, and one on friday, so it will take a while,
but I'll get it done.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the kde-core-devel