in-place-editing patch for konqueror bookmarks

[Oelewapperke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 15 January 2003 16:23, David Faure wrote:
> On Wednesday 15 January 2003 15:08, Oelewapperke wrote:
> > indeed. I will post an additional patch to do that later. (btw I never
> > ever use the menu except to get to "edit bookmarks").
>
> But what matters is that it's implemented in a consistent and generic way.
> Both KBookmarkBar and the bookmark menu use KBookmarkMenu - it's the
> class for _any_ bookmark popupmenu (main menu or submenu). So I would
> expect that most of the code goes in there.

I have made a subclass of QPopupmenu to do this. I could easily make it
inherit from KBookmarkMenu, but it would only introduce overhead as I'm
not using any functionality of that class.

> > I couldn't use the normal KToolbarButton drawing routines, as they need
> > the button to show a QPopupmenu that is constructed ahead of time,
> > something I don't do (and why should I ? It slows the startup time
>
> You can pass a new but empty QPopupMenu to KToolbatButton, and connect
> to aboutToShow() (from QPopupMenu). This is what the KBookmarkMenu already
> does. Which means you don't even have to do that. Simply do the changes in
> KBookmarkMenu::refill() (which is called by slotAboutToShow()).
> Or do I miss something?

this isn't an option as refill() is not virtual, I can override it in a 
subclass, but it wouldn't get called at all.

ipe_patch1 is for the directory kdelibs/kio/bookmarks
the 2 files kipebookmarkbar.cc and .h also for that directory (I am sorry but 
I cannot cvs add, because I don't have write access)

konq_patch is for kdebase/konqueror

(right mouse menu is not yet implemented, but middle click to open in a new 
tab is (for the menu's) )

still needs quite a few fixes, cleanups and additions, but I am in the middle 
of my exams, and still learning about kde too, so it will probably take a 
while.

Oelewapperke
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+JtWyJFU6C5Uo8MgRAlu1AKDWr92NKsddQVrYa+3ejB0SbUDA5ACbB6FY
3xTGaBlS2MdcNs5SZEVJKkU=
=8AlR
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ipe_patch1
Type: text/x-diff
Size: 1964 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030116/83c1745e/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kipebookmarkbar.cc
Type: text/x-c++src
Size: 3018 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030116/83c1745e/attachment.cc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kipebookmarkbar.h
Type: text/x-chdr
Size: 5244 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030116/83c1745e/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_patch
Type: text/x-diff
Size: 2974 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030116/83c1745e/attachment-0001.diff>