in-place-editing patch for konqueror bookmarks

David Faure dfaure at
Wed Jan 15 15:23:06 GMT 2003

Hash: SHA1

On Wednesday 15 January 2003 15:08, Oelewapperke wrote:
> indeed. I will post an additional patch to do that later. (btw I never ever
> use the menu except to get to "edit bookmarks").

But what matters is that it's implemented in a consistent and generic way.
Both KBookmarkBar and the bookmark menu use KBookmarkMenu - it's the
class for _any_ bookmark popupmenu (main menu or submenu). So I would
expect that most of the code goes in there.

> I couldn't use the normal KToolbarButton drawing routines, as they need the
> button to show a QPopupmenu that is constructed ahead of time, something I
> don't do (and why should I ? It slows the startup time

You can pass a new but empty QPopupMenu to KToolbatButton, and connect
to aboutToShow() (from QPopupMenu). This is what the KBookmarkMenu already does.
Which means you don't even have to do that. Simply do the changes in 
KBookmarkMenu::refill() (which is called by slotAboutToShow()).
Or do I miss something?

- -- 
David Faure -- faure at, dfaure at
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to:,
KOffice-1.2.1 is available -
Version: GnuPG v1.0.7 (GNU/Linux)


More information about the kde-core-devel mailing list