[PATCH] xmlgui: Prevent separators from appearing at the top of menus

Dave Corrie kde at davecorrie.com
Sat Feb 22 13:40:05 GMT 2003


I've attached a patch that prevents separators from appearing at the 
very top of menus. Is it ok to commit?

The need for this patch can be seen in katomic (cvs) which has a 
"Settings" menu containing two standard actions. During the xmlgui 
merging process, the two corresponding actions and the preceding 
separator are picked out from the global UI description file.

I chose to fix this not at the point of merging, but at the time the GUI 
is built because if more than one merge happens, later merges might 
place menu entries at the top of a menu, meaning that a previously 
removed separator was valid after all. The GUI building code already 
contains code to prevent two separators from appearing next to each 
other, so this patch would seem to fit well at this position.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmlgui_menu_separator.patch
Type: text/x-diff
Size: 770 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030222/8befc287/attachment.patch>

More information about the kde-core-devel mailing list