[PATCH] kopenwith.cpp bugfix and enhancement

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 11 February 2003 16:39, Willy De la Court wrote:
> fine but the caller is going to get into trouble because the m_command is only 
> filled in when the "In Terminal" is checked. Is this a problem?

No it's not - see KOpenWithDlg::text().
It only returns m_command if set (not empty). Otherwise it returns what the user types.
So basically m_command is a way for the slotOK code to return something
else than just what the user typed.

> yes it's getting clearer now i'll rewrite the patch now i only need to find a 
> var to assign the nocloseonexit checkbox.

Why? Please update from CVS, you'll see that I did this already.

> Now i'm begining to see the complexity of the question why not add a checkbox 
> to that dialog!

There's no technical problem, I was only referring to UI cluttering.

- -- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+SSmR72KcVAmwbhARAiC5AJsEgIEmzePQ/zLcSyQ5CQtpujEWVwCfVujn
8pQxXKZNpUkjSJeKvJRGOeQ=
=c9Ov
-----END PGP SIGNATURE-----