[PATCH] kmail leaking KPopupMenus

Ingo Klöcker kloecker at kde.org
Tue Dec 30 12:22:43 GMT 2003

On Tuesday 30 December 2003 13:14, André Wöbbeking wrote:
> On Tuesday 30 December 2003 12:58, Ingo Klöcker wrote:
> > b) You should delete mDnDPopup in the d'tor of KMFolderTree.
> > Otherwise we still leak a popup. Note that the user can open
> > several main windows (File->New Window) and that each main window
> > would leak one popup.
> Why? If you close a main window the popup is destroyed by Qt.

Yeah. I forgot about that.

> > c) If the popup is created on the stack (as André suggested) then
> > it has to be created each time. Since the contents of the popup is
> > static we can save the creation time by using Rolf's approach.
> About how many seconds you are speaking ;-) I think in this case it
> is better to save some memory than some milliseconds.

As long as the leak is fixed I don't really care where the popup is 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031230/37711732/attachment.sig>

More information about the kde-core-devel mailing list