[PATCH] kmail leaking KPopupMenus

[André Wöbbeking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 30 December 2003 12:58, Ingo Klöcker wrote:
> b) You should delete mDnDPopup in the d'tor of KMFolderTree.
> Otherwise we still leak a popup. Note that the user can open several
> main windows (File->New Window) and that each main window would leak
> one popup.

Why? If you close a main window the popup is destroyed by Qt.

> c) If the popup is created on the stack (as André suggested) then it
> has to be created each time. Since the contents of the popup is
> static we can save the creation time by using Rolf's approach.

About how many seconds you are speaking ;-) I think in this case it is 
better to save some memory than some milliseconds.


André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/8WwNGcp/AjG8ndYRAgrpAJ0fyM5dw0tGJbbGFOEhf1qorylWuwCfZX8k
I4hw+jbwEuZdlPo8efcx71E=
=598B
-----END PGP SIGNATURE-----