[PATCH] Re: [PATCH] Re: KMix

[Christian Esken]

On Thursday 18 December 2003 14:31, Frans Englich wrote:
> On Wednesday 17 December 2003 02:11, Christian Esken wrote:
> > On Sunday 14 December 2003 02:25, Frans Englich wrote:
> > > But. My patch increases the likelyness for getting blasted by so little
> > > it actually is ignorable. If you have a miss-behaving app, a
> > > non-normalized sound file or whatever the reason to increase the volume
> > > to a abnormal level AND then *immediately* exits your KDE session
> > > _with_ logout sound
> >
> > No need for the "logout sound". I am talking about the (restored) volume
> > on next boot.

Frans,

some words at the start. I do appreciate what you are doing. For example I 
would also like to remove the Control Center Module.

Still there are some nagging question: Why NOW? Why directly before the KDE3.2 
release? The Control Center Module is there in this form for quite some time. 
So why remove it in a hurry? Why confuse users by "slowly degrading" the 
Mixer Control Center Module. Why annoy the translators by doing many changes 
directly before the release?
I would rather remove it completely after KDE3.2 in one big blast.

> I don't get it. The logout sound will be played with the same level as the
> login sound with "my/current behavior - right? For example:
> 1) You raise the volume extremely much to listen to an Mp3 which sounds
> just fine.
> 2) You log out  - blasted by the logout sound.

Right. I don't argue that - but nobody can save the user from doing stupid 
things. If I format my hard disk with important data, I have done something 
stupid. If someone insists on pulling all volumes to maximum and then 
explicitely save it, I can't help him.

What I do not want is to set the volume to some insane level, if the user has 
no control over it. The problem is, that the startup sound is played without 
the user having control over the sound.


> The reason why this change is productive is that the current behavior is
> bad from a UI point. The current behavior is hidden to the user - it does
> "magic" things which the user does not know about. My change makes the user
> understand what's going, makes sure that the user have control over KMix

What is so "magic" on a menu item titled
"Save current voulumes as default  CTRL+S"?

I would say with the propose change the user would not understand what would 
be going on. Because "random" volumes will be saved / restored.


>Further, not trying to rush things though, but in case the previous commit 
>does not get reverted the attached patch is a obvious follow up to previous 
>change - a cleanup in kcm_kmix. Further refactoring and cleanups can be done 
>in parts of kmix AFAICT but it will have to wait until the code freeze

I believe that it is a good idea to remove the "Load Volumes" and "Save 
Current Volumes" from the control center module.
Removing the "Load volumes on login" is problematic, because you are forcing 
people in using KMix. People who run KDE, but use another mixer will NOT like 
that (because  KMix might restore "wrong" volumes).
Again (as I said in my introduction) I don't understand why it cannot wait 
after KDE3.2.

> freeze. I have a question regarding my patch though - is the desktop entry
> "ServiceTypes=Daemon" valid for kcmmodules or any others? ksycoca whines
> when run and kcm's work fine without it(my patch remove it from kmix's).
> Could someone clarify? (feel free to review and comment the patch :)

Unfortunately I don't know anything about the "ServiceType" thing. Probably 
somebody else with ksyscoca or kcm knowledge can comment?

Chris