[PATCH] Make KMainWindow::saveAutoSaveSettings() protected instead of private

David Faure faure at kde.org
Mon Dec 15 09:19:08 GMT 2003

On Saturday 13 December 2003 17:50, Ingo Klöcker wrote:
> Hi,
> in order to fix bug http://bugs.kde.org/show_bug.cgi?id=69656 (still the 
> problem with KMail/Kontact exiting if the main window is hidden in the 
> system tray and a secondary window is closed) I decided that the 
> cleanest solution is reimplementing KMainWindow::closeEvent(). In order 
> not to loose the "auto-save" functionality 
> KMainWindow::saveAutoSaveSettings() has to be called in the 
> reimplementation. But unfortunately this method is a private slot. 
> Would it be acceptable to make it protected so that it can be called 
> from the reimplemented closeEvent() (see attached patch). 
OK. I just hope people will only call it from reimplemented closeEvent()s.
In ALL other cases, setSettingsDirty should be called instead, to benefit
from the small-delay timer.

> According to 
> http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binarycompatibility.html
> this change is BIC.
No, it's BC.

David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list