[PATCH] Make KMainWindow::saveAutoSaveSettings() protected instead of private

Martijn Klingens klingens at kde.org
Sat Dec 13 17:03:16 GMT 2003

On Saturday 13 December 2003 17:50, Ingo Klöcker wrote:
> in order to fix bug http://bugs.kde.org/show_bug.cgi?id=69656 (still the
> problem with KMail/Kontact exiting if the main window is hidden in the
> system tray and a secondary window is closed) I decided that the
> cleanest solution is reimplementing KMainWindow::closeEvent(). In order
> not to loose the "auto-save" functionality
> KMainWindow::saveAutoSaveSettings() has to be called in the
> reimplementation. But unfortunately this method is a private slot.
> Would it be acceptable to make it protected so that it can be called
> from the reimplemented closeEvent() (see attached patch). According to
> http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binaryc
>ompatibility.html this change is BIC.

B_I_C? ;-) (Yes, I know what you mean.)

Anyway, you're missing an @since in the docs. The rest seems ok to me, but I'm 
not KMainWindow's maintainer.


More information about the kde-core-devel mailing list